[3.13] gh-127421: Fix race in test_start_new_thread_failed (GH-127549)#127574
Merged
mpage merged 1 commit intopython:3.13from Dec 3, 2024
Merged
[3.13] gh-127421: Fix race in test_start_new_thread_failed (GH-127549)#127574mpage merged 1 commit intopython:3.13from
mpage merged 1 commit intopython:3.13from
Conversation
…27549) Fix race in test_start_new_thread_failed When we succeed in starting a new thread, for example if setrlimit was ineffective, we must wait for the newly spawned thread to exit. Otherwise, we run the risk that the newly spawned thread will race with runtime finalization and access memory that has already been clobbered/freed. `_thread.start_new_thread()` only spawns daemon threads, which the runtime does not wait for at shutdown, and does not return a handle. Use `_thread.start_joinable_thread()` and join the resulting handle when the thread is started successfully. (cherry picked from commit 13b68e1) Co-authored-by: mpage <mpage@meta.com>
This was referenced Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix race in test_start_new_thread_failed
When we succeed in starting a new thread, for example if setrlimit
was ineffective, we must wait for the newly spawned thread to exit.
Otherwise, we run the risk that the newly spawned thread will race
with runtime finalization and access memory that has already been
clobbered/freed.
_thread.start_new_thread()only spawns daemon threads, which the runtimedoes not wait for at shutdown, and does not return a handle. Use
_thread.start_joinable_thread()and join the resulting handle whenthe thread is started successfully.
(cherry picked from commit 13b68e1)
Co-authored-by: mpage mpage@meta.com
test_start_new_thread_failedflaky: failed on macOS (free threading) #127421