[3.7] bpo-9566: Fix compiler warnings on Windows#12920

vstinner · 2019-04-23T08:09:06Z

Backport changes from master:

bpo-9566: Fix compiler warnings in gcmodule.c (bpo-32805: Fix compiler warnings in gcmodule.c #11010)
bpo-30465: Fix C downcast warning on Windows in ast.c (bpo-30465: Fix C downcast warning on Windows in ast.c #6593)
bpo-9566: Fix compiler warnings in peephole.c (bpo-9566: Fix compiler warnings in peephole.c #10652)
bpo-27645, sqlite: Fix integer overflow on sleep (bpo-27645, sqlite: Fix integer overflow on sleep #6594)

https://bugs.python.org/issue9566

Change PyDTrace_GC_DONE() argument type from int to Py_ssize_t. (cherry picked from commit edad38e)

ast.c: fstring_fix_node_location() downcasts a pointer difference to a C int. Replace int with Py_ssize_t to fix the compiler warning. (cherry picked from commit fb7e799)

(cherry picked from commit 028f0ef)

Use the _PyTime_t type and round away from zero (ROUND_UP, _PyTime_ROUND_TIMEOUT) the sleep duration, when converting a Python object to seconds and then to milliseconds. Raise an OverflowError in case of overflow. Previously the (int)double conversion rounded towards zero (ROUND_DOWN). (cherry picked from commit ca40501)

jkloth and others added 4 commits April 23, 2019 10:03

bpo-9566: Fix compiler warnings in gcmodule.c (GH-11010)

00cc744

Change PyDTrace_GC_DONE() argument type from int to Py_ssize_t. (cherry picked from commit edad38e)

bpo-30465: Fix C downcast warning on Windows in ast.c (#6593)

3ff3ebd

ast.c: fstring_fix_node_location() downcasts a pointer difference to a C int. Replace int with Py_ssize_t to fix the compiler warning. (cherry picked from commit fb7e799)

bpo-9566: Fix compiler warnings in peephole.c (GH-10652)

353873d

(cherry picked from commit 028f0ef)

bedevere-bot added the awaiting core review label Apr 23, 2019

the-knights-who-say-ni added the CLA signed label Apr 23, 2019

vstinner added the skip news label Apr 23, 2019

vstinner changed the title ~~[3.7] Fix compiler warnings on Windows~~ [3.7] bpo-9566: Fix compiler warnings on Windows Apr 23, 2019

vstinner merged commit 8a9a6b4 into python:3.7 Apr 23, 2019

bedevere-bot removed the awaiting core review label Apr 23, 2019

vstinner deleted the fix_win_warn37 branch April 23, 2019 08:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[3.7] bpo-9566: Fix compiler warnings on Windows#12920