gh-132775: Clean Up Cross-Interpreter Error Handling#135369
Merged
ericsnowcurrently merged 2 commits intopython:mainfrom Jun 13, 2025
Merged
gh-132775: Clean Up Cross-Interpreter Error Handling#135369ericsnowcurrently merged 2 commits intopython:mainfrom
ericsnowcurrently merged 2 commits intopython:mainfrom
Conversation
ericsnowcurrently
added
skip news
needs backport to 3.14
neonene
reviewed
Jun 11, 2025
Python/crossinterp.c
Outdated
| }; | ||
| if (override != NULL) { | ||
| err = *override; | ||
| *override = (_PyXI_error_override){0}; |
Contributor
There was a problem hiding this comment.
test_call passes without the line in my case.
Python/crossinterp.c
Outdated
| if (override == NULL) { | ||
| override = &_override; | ||
| } | ||
| _PyXI_errcode errcode = override->code; |
Contributor
There was a problem hiding this comment.
For test_running, putting _override.code = errcode; in the _PyXI_ERR_ALREADY_RUNNING case (several lines below) works well for me.
| } | ||
| else { | ||
| PyErr_SetObject(exctype, tbexc); | ||
| return; |
Contributor
There was a problem hiding this comment.
tbexc seems to be leaking.
Member
Author
There was a problem hiding this comment.
fixed
Thanks for tracking this down! I don't know how you find these things so quickly. 😄
Contributor
There was a problem hiding this comment.
Bisection might be effective using Windows binaries? Not so quick, but even I could be a tester to share the burden.
| const char *msg = error->override != NULL | ||
| ? error->override->msg | ||
| : error->uncaught.msg; | ||
| _set_xid_lookup_failure(tstate, NULL, msg, cause); |
Contributor
There was a problem hiding this comment.
cause seems to be leaking.
Member
Author
|
Hmm, I forgot to mark this as "draft". Sorry about that. |
|
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 13, 2025
…135369) In this refactor we: * move some code around * make a couple of typedefs opaque * decouple errors from session state * improve tracebacks for propagated exceptions This change helps simplify several upcoming changes. (cherry picked from commit c7f4a80) Co-authored-by: Eric Snow <[email protected]>
|
GH-135492 is a backport of this pull request to the 3.14 branch. |
ericsnowcurrently
added a commit
that referenced
this pull request
Jun 14, 2025
In this refactor we: * move some code around * make a couple of typedefs opaque * decouple errors from session state * improve tracebacks for propagated exceptions This change helps simplify several upcoming changes. (cherry picked from commit c7f4a80, AKA gh-135369) Co-authored-by: Eric Snow <[email protected]>
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Jun 19, 2025
…135369) In this refactor we: * move some code around * make a couple of typedefs opaque * decouple errors from session state * improve tracebacks for propagated exceptions This change helps simplify several upcoming changes.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…135369) In this refactor we: * move some code around * make a couple of typedefs opaque * decouple errors from session state * improve tracebacks for propagated exceptions This change helps simplify several upcoming changes.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…135369) In this refactor we: * move some code around * make a couple of typedefs opaque * decouple errors from session state * improve tracebacks for propagated exceptions This change helps simplify several upcoming changes.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…135369) In this refactor we: * move some code around * make a couple of typedefs opaque * decouple errors from session state * improve tracebacks for propagated exceptions This change helps simplify several upcoming changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this refactor we:
This change helps simplify several upcoming changes.