bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [locks]#13920
Merged
miss-islington merged 5 commits intopython:masterfrom Sep 10, 2019
Merged
bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [locks]#13920miss-islington merged 5 commits intopython:masterfrom
miss-islington merged 5 commits intopython:masterfrom
Conversation
This PR deprecate explicit loop parameters in all public asyncio APIs This issues is split to be easier to review. Third step: locks.py
Contributor
Author
|
Please don't merge because |
Contributor
Author
|
@asvetlov I think this PR is ready now |
Contributor
Author
|
ping @asvetlov :-) |
Contributor
Author
|
ping @asvetlov |
asvetlov
approved these changes
Sep 10, 2019
Contributor
asvetlov
left a comment
asvetlov
left a comment
There was a problem hiding this comment.
LGTM
Sorry for the delay.
Thank for your patience.
Contributor
|
Thanks @eamanu for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Contributor
|
I'm having trouble backporting to |
Contributor
|
Thanks @eamanu for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 10, 2019
…Is [locks] (pythonGH-13920) This PR deprecate explicit loop parameters in all public asyncio APIs This issues is split to be easier to review. Third step: locks.py https://bugs.python.org/issue36373 (cherry picked from commit 537877d) Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>
|
GH-15835 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 10, 2019
…Is [locks] (GH-13920) This PR deprecate explicit loop parameters in all public asyncio APIs This issues is split to be easier to review. Third step: locks.py https://bugs.python.org/issue36373 (cherry picked from commit 537877d) Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…PIs [locks] (pythonGH-13920) This PR deprecate explicit loop parameters in all public asyncio APIs This issues is split to be easier to review. Third step: locks.py https://bugs.python.org/issue36373
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecate explicit loop parameters in all public asyncio APIs
This issues is split to be easier to review.
Third step: locks.py
https://bugs.python.org/issue36373
Automerge-Triggered-By: @asvetlov