bpo-37289: Remove 'if False' handling in the peephole optimizer#14099
Merged
pablogsal merged 2 commits intopython:masterfrom Jun 15, 2019
Merged
bpo-37289: Remove 'if False' handling in the peephole optimizer#14099pablogsal merged 2 commits intopython:masterfrom
pablogsal merged 2 commits intopython:masterfrom
Conversation
pablogsal
changed the title
pablogsal
changed the title
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
What if PyObject_IsTrue() returns -1?
Member
Author
|
@serhiy-storchaka It goes to the break and skips to the next bytecode, right? I am missing something? |
Member
|
It should be handled as an error. |
Member
Author
|
@serhiy-storchaka Done in 455cbc7 |
serhiy-storchaka
approved these changes
Jun 15, 2019
Contributor
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
Contributor
|
I'm having trouble backporting to |
|
GH-14111 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 15, 2019
…onGH-14099) (cherry picked from commit 7a68f8c) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Contributor
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-14112 is a backport of this pull request to the 3.8 branch. |
pablogsal
added a commit
that referenced
this pull request
Jun 15, 2019
pablogsal
added a commit
that referenced
this pull request
Jun 15, 2019
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37289