bpo-36511 add arm32 buildbot diagnostic messages#14251
Conversation
|
I tried skimming the buildbot documentation before posting this at https://devguide.python.org/buildworker/ and https://docs.buildbot.net/current/manual/index.html and I don't see anything obvious that needs to be configured to allow calling ssh.exe |
|
It looks like Maybe add fallback checks for |
|
You can test this by launching |
|
still testing these changes on the buildbot worker machine |
Tools/buildbot/remoteDeploy.bat
Outdated
| rem Used by the buildbot "remotedeploy" step. | ||
| setlocal | ||
|
|
||
| set PATH=%PATH%;%SystemRoot%\SysNative\OpenSSH |
There was a problem hiding this comment.
Unfortunately, SysNative only works in 32-bit command prompt. Add both SysNative and System32 here to ensure it works even if we switch to a 64-bit process one day.
There was a problem hiding this comment.
System32\OpenSSH is always on the path right now, whether I run C:\Windows\SysWOW64\cmd.exe or C:\Windows\System32\cmd.exe. I can add it again, but it seemed redundant
|
Sorry, @paulmon and @zooba, I could not cleanly backport this to |
|
GH-14279 is a backport of this pull request to the 3.8 branch. |
* master: (599 commits) Docs: Improved phrasing (pythonGH-14069) Remove redundant if check from optional argument function in argparse. (pythonGH-8766) bpo-37289: Add a test for if with ifexpr in the peephole optimiser to detect regressions (pythonGH-14127) Update What's New in Python 3.9 (pythonGH-14253) bpo-36511: Improve ARM32 buildbot scripts (pythonGH-14251) bpo-37151: remove _PyCFunction_FastCallDict (pythonGH-14269) Fix typo, 'widger' -> 'widget', in idlelib/tree.py (pythonGH-14263) Fix bpo number in News file. (pythonGH-14260) bpo-37342: Fix the incorrect nb_index's type in typeobj documentation (pythonGH-14241) Update What's New in Python 3.8 (pythonGH-14239) bpo-36710: Use tstate in pylifecycle.c (pythonGH-14249) Add missing single quote in io.TextIOWrapper.reconfigure documentation (pythonGH-14246) bpo-36511: Add buildbot scripts and fix tests for Windows ARM32 buildbot (pythonGH-13454) bpo-37333: Ensure IncludeTkinter has a value (pythonGH-14240) bpo-37331: Clarify format of socket handler messages in the documentation. (pythonGH-14234) bpo-37258: Not a bug, but added a unit test and updated documentation. (pythonGH-14229) bpo-36710: Remove PyImport_Cleanup() function (pythonGH-14221) Fix name of '\0'. (pythonGH-14222) bpo-36710: Add tstate parameter in import.c (pythonGH-14218) Document typing.ForwardRef (pythonGH-14216) ...
5 participants
I'm trying figure out why ssh.exe doesn't work on Windows when the buildbot worker is running.
The path includes
C:\WINDOWS\System32\OpenSSH\and the location ofssh.exeon my machine isC:\WINDOWS\System32\OpenSSH\ssh.exePreviously the script had
ssh.exeexpecting to find it on the path. But at runtime there was this error message:'ssh' is not recognized as an internal or external commandSo I tried adding
if "%SSH%"=="" if EXIST %WINDIR%\System32\OpenSSH\ssh.exe (set SSH=%WINDIR%\System32\OpenSSH\ssh.exe)and calling%SSH%in the scriptNow it echos
SSH =meaning that the test forEXISTfailed. From the same console window that I'm launching the worker from ssh.exe is on the path and works fine.Any ideas? @zware @zooba
EDIT: Steve pointed out in the comments of #13454 that it might be 32-bit vs 64-bit issue. I had 32-bit python installed and ssh.exe appears to be 64-bit only. Trying to update the worker to python 64-bit
https://bugs.python.org/issue36511