bpo-37459: importlib docs improperly reference get_resource_loader()#14568
bpo-37459: importlib docs improperly reference get_resource_loader()#14568warsaw merged 2 commits intopython:masterfrom
Conversation
aeros
left a comment
aeros
left a comment
There was a problem hiding this comment.
Approved, verified that this is the only reference to get_resource_loader(fullname) across the cpython repository. Based on the described functionality, get_resource_reader() seems to be the appropriate replacement.
Doc/library/importlib.rst
Outdated
|
|
||
| Loaders that wish to support resource reading are expected to | ||
| provide a method called ``get_resource_loader(fullname)`` which | ||
| provide a method called ``get_resource_reader()`` which |
There was a problem hiding this comment.
Please restore the fullname argument here.
warsaw
left a comment
warsaw
left a comment
There was a problem hiding this comment.
Thanks for the fix; one change is needed.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks @aldwinaldwin for the PR, and @warsaw for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
@warsaw: Please replace |
|
GH-14580 is a backport of this pull request to the 3.8 branch. |
…ythonGH-14568) * bpo-37459: importlib docs improperly reference get_resource_loader() (cherry picked from commit b607d99) Co-authored-by: aldwinaldwin <[email protected]>
|
GH-14581 is a backport of this pull request to the 3.7 branch. |
…ythonGH-14568) * bpo-37459: importlib docs improperly reference get_resource_loader() (cherry picked from commit b607d99) Co-authored-by: aldwinaldwin <[email protected]>
…H-14568) (GH-14580) * bpo-37459: importlib docs improperly reference get_resource_loader() (cherry picked from commit b607d99) Co-authored-by: aldwinaldwin <[email protected]>
…H-14568) (GH-14581) * bpo-37459: importlib docs improperly reference get_resource_loader() (cherry picked from commit b607d99) Co-authored-by: aldwinaldwin <[email protected]>
|
@warsaw Good catch, I should've searched the repository for |
|
No worries @aeros167 ! Thanks for helping out! |
…ython#14568) * bpo-37459: importlib docs improperly reference get_resource_loader()
…ython#14568) * bpo-37459: importlib docs improperly reference get_resource_loader()
6 participants
Gregory Szorc: "The documentation in importlib.rst says that a loader should implement
get_resource_loader(fullname). This is the only occurrence ofget_resource_loaderin the CPython source tree. It should be changed toget_resource_reader()."https://bugs.python.org/issue37459