bpo-30284: Fix regrtest for out of tree build#1481
Merged
vstinner merged 1 commit intopython:masterfrom Jun 14, 2017
vstinner:master_ro
Merged
bpo-30284: Fix regrtest for out of tree build#1481vstinner merged 1 commit intopython:masterfrom vstinner:master_ro
vstinner merged 1 commit intopython:masterfrom
vstinner:master_ro
Conversation
Member
Author
|
I tested again with a fresh read-only source directory and I'm able to build Python and run tests with this change (whereas running tests fails without this change). |
Member
Author
|
Hum, it seems like the variable is not available on Windows: |
Use a build/ directory in the build directory, not in the source directory, since the source directory may be read-only and must not be modified. Fallback on the source directory if the build directory is not available (missing "abs_builddir" sysconfig variable).
Member
Author
|
I checked manually that it fixes the issue of read-only source tree: I'm now able to run tests from the build directory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a build/ directory in the build directory, not in the source
directory, since the source directory may be read-only and must not
be modified.