bpo-37942: Improve argument clinic float converter#15470
Merged
rhettinger merged 6 commits intopython:masterfrom Aug 25, 2019
Merged
bpo-37942: Improve argument clinic float converter#15470rhettinger merged 6 commits intopython:masterfrom
rhettinger merged 6 commits intopython:masterfrom
Conversation
rhettinger
added
type-bug
serhiy-storchaka
approved these changes
Aug 24, 2019
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM.
Do you want to add the same optimization in getargs.c?
Baseline timing: ./python.exe -m timeit -r11 -s 'from statistics import _normal_dist_inv_cdf as f' -s 't=0.75,0.0,1.0' 'f(*t)' 5000000 loops, best of 11: 61.1 nsec per loop Improved timing: ./python.exe -m timeit -r11 -s 'from statistics import _normal_dist_inv_cdf as f' -s 't=0.75,0.0,1.0' 'f(*t)' 5000000 loops, best of 11: 52.5 nsec per loop
Contributor
Author
|
Serhiy, do you know how to regenerate or edit 'Lib/test/clinic.test' ? |
Contributor
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Contributor
|
Sorry, @rhettinger, I could not cleanly backport this to |
rhettinger
added a commit
to rhettinger/cpython
that referenced
this pull request
Aug 25, 2019
) (cherry picked from commit aef9ad8)
|
GH-15480 is a backport of this pull request to the 3.8 branch. |
rhettinger
added a commit
that referenced
this pull request
Aug 25, 2019
Member
I use the following line: mv Lib/test/clinic.test{,.c}; ./python Tools/clinic/clinic.py --force Lib/test/clinic.test.c; mv Lib/test/clinic.test{.c,} |
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37942