Conversation
|
@DinoV: Please replace |
|
GH-15828 is a backport of this pull request to the 3.8 branch. |
|
GH-15829 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 359143c) Co-authored-by: dalgarno <32097481+dalgarno@users.noreply.github.com>
|
Oh, I just created a thread for this PR... https://discuss.python.org/t/fixing-simple-typo-in-comment-not-document/2297 |
(cherry picked from commit 359143c) Co-authored-by: dalgarno <32097481+dalgarno@users.noreply.github.com>
(cherry picked from commit 359143c) Co-authored-by: dalgarno <32097481+dalgarno@users.noreply.github.com>
Hmm, I can understand the concern about the messy commit logs, but I would strongly disagree that we should not accept these types of PRs. I don't think we should explicitly encourage them, but code comment typo fixing PRs provide a great introduction into the CPython workflow for new contributors. Many first time contributors start out with typo fixes, and then move on to making more impactful changes once they become more familiar with the workflow. Also, if you want to go through the git log without seeing the typo fixes, you can simply use:
|
Fixes a small typo in the dictobject comment. No
bpoas it's a trivial fix.