bpo-32972: Document IsolatedAsyncioTestCase of unittest module

[tirkarthi]

• Document unittest.IsolatedAsyncioTestCase API
• Add a simple example with respect to order of evaluation of setup and teardown calls.

https://bugs.python.org/issue32972

Automerge-Triggered-By: @asvetlov

[asvetlov]

Looks good, thank you.

Please fix a couple notes

[asvetlov]

import paths should be fixed before the merge

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[tirkarthi]

Thanks Andrew, I didn't know about the import. It makes it more clean and user doesn't need to know about async_case module too. I have fixed the imports as per comments. I think this feature also deserves a better attention so I have added it to the What's new document under unittest section with a simple example. Thoughts?

[asvetlov]

I think this feature also deserves a better attention so I have added it to the What's new document under unittest section with a simple example. Thoughts?

Excellent idea! Please do

[tirkarthi]

Sure, added at https://github.com/python/cpython/pull/15878/files#diff-77c703d9a958f6a4b0dc2f692b3fd5b3R1114 . Please review the wording and example.

[asvetlov]

The example is fine. Please address my last comments.

[tirkarthi]

Thanks Andrew, I have reworded ExpensiveAsyncConnection to AsyncConnection . I have removed the sync_connection example and moved the events assertion out to docs with a statement as suggested.

Yes, test discovery works better and friendly. I must admit I copied the test from async_case as example which was the reason and I just learned about TestCase instantiation while writing this example :) Your suggestion is better and changed it to test discovery.

[asvetlov]

Perfect!

[asvetlov]

there are two extra lines in example that should be dropped

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[asvetlov]

Thank you very much!
Done well

[tirkarthi]

Ah sorry, I removed the connection example and overlooked the setup and teardown which is not used. Thanks.

[tirkarthi]

Thank you very much Andrew for all the guidance :)

[miss-islington]

@tirkarthi: Status check is done, and it's a success ✅ .

[miss-islington]

Thanks @tirkarthi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

[bedevere-bot]

GH-15918 is a backport of this pull request to the 3.8 branch.