bpo-38142: Updated _hashopenssl.c to be PEP 384 compliant

[tiran]

The _hashlib OpenSSL wrapper extension module is now PEP 384 compliant.

Also remove refleak test from test_hashlib. The updated type no longer accepts random arguments to __init__.

https://bugs.python.org/issue38142

[eduardo-elizondo]

Since EVP is now a heap allocated type, you should now properly refcount the type as well. You can read the details in: https://docs.python.org/3.8/whatsnew/3.8.html#changes-in-the-c-api, search for bpo-35810

Anyways, the TL;DR is that EVP_dealloc should now be:

static void
EVP_dealloc(EVPobject *self)
{
    PyTypeObject *tp = Py_TYPE(self);
    if (self->lock != NULL)
        PyThread_free_lock(self->lock);
    EVP_MD_CTX_free(self->ctx);
    PyObject_Del(self);
    Py_DECREF(tp);
}

[tiran]

Since EVP is now a heap allocated type, you should now properly refcount the type as well. You can read the details in: docs.python.org/3.8/whatsnew/3.8.html#changes-in-the-c-api, search for bpo-35810

Thanks! I missed the note. :)

[eduardo-elizondo]

Perfect! This LGTM now!

[eduardo-elizondo]

Agh I forget I don't have the commit bit here. Let's ping someone else to merge, cc @ericsnowcurrently @DinoV

[bedevere-bot]

@tiran: Please replace # with GH- in the commit message next time. Thanks!