bpo-39884: Add method name in "bad call flags" error#18944
Merged
vstinner merged 2 commits intopython:masterfrom Mar 12, 2020
vstinner:bad_call_flags
Merged
bpo-39884: Add method name in "bad call flags" error#18944vstinner merged 2 commits intopython:masterfrom vstinner:bad_call_flags
vstinner merged 2 commits intopython:masterfrom
vstinner:bad_call_flags
Conversation
PyDescr_NewMethod() and PyCFunction_NewEx() now include the method name in the SystemError "bad call flags" error message to ease debug.
ngie-eign
approved these changes
Mar 12, 2020
Contributor
ngie-eign
left a comment
ngie-eign
left a comment
There was a problem hiding this comment.
Nice! That's a lot simpler than I thought it would be...
Contributor
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Contributor
|
Sorry @vstinner, I had trouble checking out the |
|
GH-18956 is a backport of this pull request to the 3.8 branch. |
|
vstinner
added a commit
that referenced
this pull request
Mar 12, 2020
vstinner
added a commit
that referenced
this pull request
Mar 12, 2020
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyDescr_NewMethod() and PyCFunction_NewEx() now include the method
name in the SystemError "bad call flags" error message to ease debug.
https://bugs.python.org/issue39884