bpo-1635741: Port _lzma module to multiphase initialization #19382
Merged
corona10 merged 5 commits intopython:masterfrom Jun 22, 2020
Merged
bpo-1635741: Port _lzma module to multiphase initialization #19382corona10 merged 5 commits intopython:masterfrom
corona10 merged 5 commits intopython:masterfrom
Conversation
Member
Author
|
I ran the several leak test also for subinterp. class SubinterpThreadingTests(unittest.TestCase):
def test_lzma_subinterp(self):
code = textwrap.dedent(r"""
import os
from lzma import LZMACompressor, LZMADecompressor, LZMAError
lzc = LZMACompressor()
lzd = LZMADecompressor()
def noop(*args):
pass
os.register_at_fork(after_in_child=noop)
""")
ret = support.run_in_subinterp(code) |
Member
Author
|
@shihai1991 Can you please take a look? |
shihai1991
reviewed
Apr 5, 2020
7558ffb to
525190c
Compare
Member
Author
|
@vstinner Please take a look :) |
Member
Author
with patch (https://bugs.python.org/issue40149#msg365560) |
498affa to
c556f77
Compare
vstinner
approved these changes
Jun 22, 2020
Member
vstinner
left a comment
There was a problem hiding this comment.
LGTM. Just two minor coding style remarks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue1635741