bpo-40149: Implement traverse in _abc._abc_data#19412
Merged
vstinner merged 1 commit intopython:masterfrom Apr 7, 2020
vstinner:fix_abc
Merged
bpo-40149: Implement traverse in _abc._abc_data#19412vstinner merged 1 commit intopython:masterfrom vstinner:fix_abc
vstinner merged 1 commit intopython:masterfrom
vstinner:fix_abc
Conversation
Implement traverse and clear slots in _abc._abc_data type.
corona10
approved these changes
Apr 7, 2020
Member
corona10
left a comment
There was a problem hiding this comment.
Looks good, I've checked the patch on my local machine.
If CIs are passed. It is good to go :)
Member
|
This PR looks good to me, but I raised this error again after I use this PR, Lol~ |
Member
Author
This change doesn't completely fix https://bugs.python.org/issue40149 See https://bugs.python.org/issue40149#msg365913 and https://bugs.python.org/issue40217 |
Member
Got it, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement tp_traverse and tp_clear slots in _abc._abc_data type.
https://bugs.python.org/issue40149