bpo-40275: lazy import module in test.supports' decorators#20131
Merged
vstinner merged 4 commits intopython:masterfrom May 18, 2020
Merged
bpo-40275: lazy import module in test.supports' decorators#20131vstinner merged 4 commits intopython:masterfrom
vstinner merged 4 commits intopython:masterfrom
Conversation
shihai1991
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ethanfurman,
ncoghlan,
vsajip and
warsaw
as code owners
Member
Author
|
@vstinner @serhiy-storchaka Hi, pls take a look if you have free time. |
vstinner
reviewed
May 18, 2020
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
The @support.requires_zlib change works as expected:
vstinner@apu$ find -name "zlib*so" -delete
vstinner@apu$ ./python -m test -v test_zipfile
(...)
test_create_command (test.test_zipfile.CommandLineTest) ... skipped 'requires zlib'
(...)
vstinner
reviewed
May 18, 2020
Member
|
Thanks @shihai1991, I merged your PR. I rewrote your commit message to better describe what the commit does. |
Member
Author
Oh, thanks, victor. |
arturoescaip
pushed a commit
to arturoescaip/cpython
that referenced
this pull request
May 24, 2020
Make the the following imports lazy in test.support: * bz2 * gzip * lzma * resource * zlib The following test.support decorators now need to be called with parenthesis: * @support.requires_bz2 * @support.requires_gzip * @support.requires_lzma * @support.requires_zlib For example, "@requires_zlib" becomes "@requires_zlib()".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40275