Fix typing problems reported by mypy in pegen#20297
Merged
pablogsal merged 1 commit intopython:masterfrom May 21, 2020
Merged
Conversation
pablogsal
force-pushed
the
fix_mypy
branch
2 times, most recently
from
e1aa8e2 to
3f8bbc8
Compare
lysnikolaou
approved these changes
May 21, 2020
Member
lysnikolaou
left a comment
lysnikolaou
left a comment
There was a problem hiding this comment.
Didn't even know about field, really nice. LGTM!
Contributor
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Contributor
|
Sorry, @pablogsal, I could not cleanly backport this to |
|
GH-20300 is a backport of this pull request to the 3.9 branch. |
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
May 21, 2020
(cherry picked from commit d10fef3) Co-authored-by: Pablo Galindo <[email protected]>
pablogsal
added a commit
that referenced
this pull request
May 21, 2020
) (cherry picked from commit d10fef3) Co-authored-by: Pablo Galindo <[email protected]>
arturoescaip
pushed a commit
to arturoescaip/cpython
that referenced
this pull request
May 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some general fixes that mypy was complaining about and use a type-specialized function instead of
visitto avoid dealing withAnyeverywhere. Also, executed "black" over the source.