Skip to content

bpo-40275: test.support.check_impl_detail() uses sys.implementation#20468

Merged
vstinner merged 1 commit intopython:masterfrom
vstinner:check_impl_detail
May 27, 2020
Merged

bpo-40275: test.support.check_impl_detail() uses sys.implementation#20468
vstinner merged 1 commit intopython:masterfrom
vstinner:check_impl_detail

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented May 27, 2020

check_impl_detail() of test.support now uses sys.implementation.name,
instead of platform.python_implementation().lower(). This change
prepares test.support to import the platform module lazily.

https://bugs.python.org/issue40275

check_impl_detail() of test.support now uses sys.implementation.name,
instead of platform.python_implementation().lower(). This change
prepares test.support to import the platform module lazily.
@vstinner
Copy link
Member Author

I tested manually: PyPy3 provides sys.implementation:

$ pypy3 -c 'import sys; print(sys.implementation.name)'
pypy
$ python3 -c 'import sys; print(sys.implementation.name)'
cpython

$ pypy3 -V
Python 3.6.9 (78d4c48fa091, Apr 30 2020, 07:55:31)
[PyPy 7.3.1 with GCC 10.0.1 20200328 (Red Hat 10.0.1-0.11)]
$ python3 -VV
Python 3.8.2 (default, Feb 28 2020, 00:00:00) 
[GCC 10.0.1 20200216 (Red Hat 10.0.1-0.8)]

@vstinner vstinner merged commit b0461e1 into python:master May 27, 2020
@vstinner vstinner deleted the check_impl_detail branch May 27, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants