bpo-40275: test.support imports subprocess lazily#20471
Merged
vstinner merged 1 commit intopython:masterfrom May 27, 2020
vstinner:support_lazily
Merged
bpo-40275: test.support imports subprocess lazily#20471vstinner merged 1 commit intopython:masterfrom vstinner:support_lazily
vstinner merged 1 commit intopython:masterfrom
vstinner:support_lazily
Conversation
test.support module now imports the platform and subprocess modules lazily to reduce the number of modules imported by "import test.support". With this change, the threading module is no longer imported indirectly by "import test.support". Use sys.version rather than platform.machine() to detect the Windows ARM32 buildbot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test.support module now imports the platform and subprocess modules
lazily to reduce the number of modules imported by
"import test.support".
With this change, the threading module is no longer imported
indirectly by "import test.support".
Use sys.version rather than platform.machine() to detect the Windows
ARM32 buildbot.
https://bugs.python.org/issue40275