bpo-40275: Add warnings_helper submodule in test.support#20797
bpo-40275: Add warnings_helper submodule in test.support#20797vstinner merged 2 commits intopython:masterfrom
Conversation
|
@vstinner Hi, victor. Pls take a look if you have free times. Thanks. |
vstinner
left a comment
There was a problem hiding this comment.
In support/init.py, "import warnings" is only used by _MemoryWatchdog. Can you please move the import inside _MemoryWatchdog.start()? That's the whole purpose of https://bugs.python.org/issue40275 : remove imports.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
make sense, done. |
thanks, victor. |
move the following functions, classes to warnings_helper:
https://bugs.python.org/issue40275