[3.9] bpo-40939: Fix test_keyword for the old parser#20814
Merged
pablogsal merged 3 commits intopython:3.9from Jun 11, 2020
Merged
[3.9] bpo-40939: Fix test_keyword for the old parser#20814pablogsal merged 3 commits intopython:3.9from
pablogsal merged 3 commits intopython:3.9from
Conversation
pablogsal
changed the title
Member
|
You beat me to it!! Should we maybe also rename the easter egg in 3.9 as per @vstinner's suggestion? |
Member
Author
Remember: fastest gun in the west 🔫 🤠
¯_(ツ)_/¯ As you prefer: there is no possibility that it needs to be future-proof now :P |
Member
Time and time again!
You both know best. |
Member
Author
Ok, will change it here then |
vstinner
reviewed
Jun 11, 2020
Lib/test/test_keyword.py
Outdated
| for key in keyword.kwlist: | ||
| all_keywords = set(keyword.kwlist) | ||
| if use_old_parser(): | ||
| all_keywords -= {'__new_parser__'} |
Member
There was a problem hiding this comment.
I would use discard(), but your code is correct ;-)
Suggested change
| all_keywords -= {'__new_parser__'} | |
| all_keywords.discard('__new_parser__') |
Member
Author
There was a problem hiding this comment.
I would use discard(), but your code is correct ;-)
I like discard() :)
|
Member
Author
|
The buildbot failure is unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40939