bpo-1635741: Port _dbm module to multiphase initialization#20848
Merged
corona10 merged 9 commits intopython:masterfrom Jun 15, 2020
Merged
bpo-1635741: Port _dbm module to multiphase initialization#20848corona10 merged 9 commits intopython:masterfrom
corona10 merged 9 commits intopython:masterfrom
Conversation
Member
Author
|
@shihai1991 PTAL! |
Member
Author
|
I' ve checked the memory leak with these scripts and no leaks found def test_dbm(self):
code = textwrap.dedent(r"""
import glob
import test.support
dbm = test.support.import_module('_dbm')
_fname = test.support.TESTFN
def delete_files():
for f in glob.glob(_fname + "*"):
test.support.unlink(f)
f = dbm.open(_fname, 'n')
f[b'g'] = b"indented"
f.close()
delete_files()
""")
ret = test.support.run_in_subinterp(code)
self.assertEqual(ret, 0) |
shihai1991
reviewed
Jun 13, 2020
corona10
commented
Jun 13, 2020
Member
Author
corona10
left a comment
There was a problem hiding this comment.
@shihai1991 Thanks shihai! I've updated it
vstinner
requested changes
Jun 15, 2020
|
When you're done making the requested changes, leave the comment: |
corona10
commented
Jun 15, 2020
Member
Author
corona10
left a comment
There was a problem hiding this comment.
I have made the requested changes; please review again
vstinner
reviewed
Jun 15, 2020
vstinner
reviewed
Jun 15, 2020
vstinner
reviewed
Jun 15, 2020
Co-authored-by: Victor Stinner <vstinner@python.org>
26030f1 to
b325856
Compare
vstinner
reviewed
Jun 15, 2020
Member
vstinner
left a comment
There was a problem hiding this comment.
Thanks! It's now much better!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue1635741