bpo-36346: Make unicodeobject.h C89 compatible#20934
Merged
methane merged 1 commit intopython:masterfrom Jun 17, 2020
Merged
Conversation
methane
added
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
vstinner
approved these changes
Jun 17, 2020
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. But I suggest to change the commit title to "Make unicodeobject.h C89 compatible".
| Py_UNICODE_FILL(Py_UNICODE *target, Py_UNICODE value, Py_ssize_t length) { | ||
| for (Py_ssize_t i = 0; i < length; i++) { | ||
| Py_ssize_t i; | ||
| for (i = 0; i < length; i++) { |
Member
There was a problem hiding this comment.
This change makes me sad :-( But well, as I wrote in the issue, I think that it's a good practice to try to keep C89 support for the public C API.
methane
changed the title
methane
added a commit
to methane/cpython
that referenced
this pull request
Jun 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36346
Automerge-Triggered-By: @methane