Skip to content

[3.9] bpo-40939: Do not emit deprecation warnings inside CPython for old parser APIs#21025

Merged
pablogsal merged 1 commit intopython:3.9from
pablogsal:deprecation_warnings
Jun 21, 2020
Merged

[3.9] bpo-40939: Do not emit deprecation warnings inside CPython for old parser APIs#21025
pablogsal merged 1 commit intopython:3.9from
pablogsal:deprecation_warnings

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 21, 2020 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from lysnikolaou June 21, 2020 03:06
lysnikolaou
lysnikolaou reviewed Jun 21, 2020
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with diagnostic pragmas, so I'm not the most suited to review this.

@nnemkin
Copy link
Contributor

nnemkin commented Jun 21, 2020

Consider doing this instead (in the header file):

#ifndef Py_BUILD_CODE
Py_DEPRECATED(3.9)
#endif
PyAPI_FUNC(struct _node *) PyParser_...

@pablogsal
Copy link
Member Author

pablogsal commented Jun 21, 2020

Consider doing this instead (in the header file):

Good point!

@pablogsal pablogsal force-pushed the deprecation_warnings branch from 21b84dd to e85ba58 Compare June 21, 2020 18:24
@pablogsal pablogsal merged commit 5b1a311 into python:3.9 Jun 21, 2020
@pablogsal pablogsal deleted the deprecation_warnings branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou left review comments

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @nnemkin @lysnikolaou @the-knights-who-say-ni @bedevere-bot