[3.8] bpo-32528: Document the change in inheritance of asyncio.CancelledError (GH-21474)#21476
Merged
miss-islington merged 1 commit intopython:3.8from Jul 19, 2020
Merged
Conversation
…or (pythonGH-21474) GH-msg373510 [bpo-32528]()/pythonGH-13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document. Automerge-Triggered-By: @1st1 (cherry picked from commit 2a51818) Co-authored-by: JustAnotherArchivist <JustAnotherArchivist@users.noreply.github.com>
Contributor
Author
|
@JustAnotherArchivist: Status check is done, and it's a success ✅ . |
eamanu
approved these changes
Jul 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-msg373510
[bpo-32528]()/GH-13528 changed
asyncio.CancelledErrorsuch that it no longer inherits fromconcurrent.futures.CancelledError. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.Automerge-Triggered-By: @1st1
(cherry picked from commit 2a51818)
Co-authored-by: JustAnotherArchivist JustAnotherArchivist@users.noreply.github.com
https://bugs.python.org/issue32528