bpo-41428: Implementation for PEP 604

[maggiemoss]

PEP 604 - Proposed Implementation

https://www.python.org/dev/peps/pep-0604/

Building off of the comments left on this PR here: https://github.com/pprados/cpython/tree/PEP604

https://bugs.python.org/issue41428

[gvanrossum]

Thank you so much! Give me a few days to review this. Ping me if you haven't heard from me by Wednesday!

[gvanrossum]

Great start! Here's a boatload of review comments, from whitespace nits to feature requests.

[gvanrossum]

(Presumably you were going to add more commits before asking for another review?)

[maggiemoss]

@gvanrossum thanks so much for the comments! I'll implement your suggestions and clean this up :)

[maggiemoss]

@gvanrossum

I had thought of another case we might need to handle here, and was hoping to get your input. Should this:

typing.Union[int, str] is (int | str)

evaluate to true?

[maggiemoss]

@pablogsal let me know if there are any other changes you'd like to see here.

[pablogsal]

@pablogsal let me know if there are any other changes you'd like to see here.

I just need to find some time to do another iteration 😉 Will try to do another pass by tomorrow, but we are very close! Thanks for the patience and tye good work :)

[pablogsal]

@maggiemoss I have pushed a new commit (8c06c1d) to do some simplifications and to fix some minor reference count issues and crashes. Please, check out that everything seems ok in that commit :)

[pablogsal]

This looks good to me!

Thanks for all the work and patience @maggiemoss! Great job :)

@gvanrossum I won't land it myself in case you or Maggie want to take a last check.

[gvanrossum]

I think it's good! Thanks so much Maggie for all your work.

[maggiemoss]

Thanks so much for all of your reviews and comments, I've really appreciated it. 🎉

[gvanrossum]

@maggiemoss
I noticed that some tests failed on Windows. Could it be that you need to rebase to the latest master?

"test.test_asyncio.test_sendfile.ProactorEventLoopTests.test_sendfile_close_peer_in_the_middle_of_receiving"

[pablogsal]

@maggiemoss
I noticed that some tests failed on Windows. Could it be that you need to rebase to the latest master?

"test.test_asyncio.test_sendfile.ProactorEventLoopTests.test_sendfile_close_peer_in_the_middle_of_receiving"

That's an unrelated race condition in asyncio in Windows, we can ignore it and just land

[gvanrossum]

Congrats Maggie!!