bpo-41520: Fix second codeop regression#21848

terryjreedy · 2020-08-12T17:50:12Z

Fix the regression introduced by the initial regression fix.

https://bugs.python.org/issue41520

Fix the repression introduced by the initial regression fix.

terryjreedy · 2020-08-12T18:19:37Z

The CI passed without adding warnings.catch_warnings(), but on my local machine there was an 'altered the execution environment' warning which some buildbots might turn into an error.

Carreau · 2020-08-12T18:21:30Z

currently compiling this locally and will test how that effect IPython. Thanks for the quick turnaround.

vstinner · 2020-08-12T19:53:15Z

Lib/test/test_codeop.py

+                (".*invalid", DeprecationWarning),
+                ) as w:
+            compile_command(r"'\e' is 0")
+            self.assertEqual(len(w.warnings), 2)


Would it be possible to another test which only emits a single warning? For example, keep the existing "0 is 0" test, but add your new test as a new one (don't replace the existing one).

check_warnings checks that each of the two warnings is called, so that 2 must be 1+1 and not 2+0, so the above is, in a sense, two independent tests. We are not testing builtin compile, but that compile_command only lets 1+1 of the 3+3 warnings pass to the caller.

Lib/codeop.py

Co-authored-by: Victor Stinner <vstinner@python.org>

miss-islington · 2020-08-13T17:18:53Z

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington · 2020-08-13T17:19:00Z

Sorry, @terryjreedy, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c818b15fa59039de67022c29085d439fa5d3ef95 3.9

miss-islington · 2020-08-13T17:19:02Z

Sorry @terryjreedy, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c818b15fa59039de67022c29085d439fa5d3ef95 3.8

miss-islington · 2020-08-13T17:20:27Z

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington · 2020-08-13T17:20:27Z

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington · 2020-08-13T17:20:31Z

Sorry, @terryjreedy, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c818b15fa59039de67022c29085d439fa5d3ef95 3.8

miss-islington · 2020-08-13T17:20:36Z

Sorry @terryjreedy, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c818b15fa59039de67022c29085d439fa5d3ef95 3.9

Fix the repression introduced by the initial regression fix. (cherry picked from commit c818b15)

* bpo-41520: Fix second codeop repression Fix the repression introduced by the initial regression fix.. (cherry picked from commit c818b15) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

bedevere-bot · 2020-08-13T17:41:10Z

GH-21860 is a backport of this pull request to the 3.9 branch.

terryjreedy · 2020-08-13T17:47:44Z

Not checking out branches is bad. 'warnings_helper' does not exist in 3.9-, so had to be turned back into 'support'. Not sure why this caused a merge conflict, rather than a test failure. I requested that the 3.9 backport be backported to 3.8.

Fix the repression introduced by the initial regression fix. (cherry picked from commit c818b15) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

bedevere-bot · 2020-08-13T18:21:57Z

GH-21862 is a backport of this pull request to the 3.8 branch.

Fix the repression introduced by the initial regression fix. (cherry picked from commit c818b15) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit f24430f) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

* bpo-41520: Fix second codeop repression Fix the repression introduced by the initial regression fix.

terryjreedy added 2 commits August 12, 2020 13:40

bpo-41520: Fix second codeop repression

450ede4

Fix the repression introduced by the initial regression fix.

Fix news.

bb43d3e

terryjreedy added type-bug An unexpected behavior, bug, or error needs backport to 3.8 labels Aug 12, 2020

terryjreedy requested review from csabella and vstinner August 12, 2020 17:50

the-knights-who-say-ni added the CLA signed label Aug 12, 2020

bedevere-bot added the awaiting core review label Aug 12, 2020

terryjreedy mentioned this pull request Aug 12, 2020

bpo-41520: codeop no longer ignores SyntaxWarning #21838

Merged

terryjreedy changed the title ~~bpo-41520: Fix second codeop repression~~ bpo-41520: Fix second codeop regression Aug 12, 2020

Don't alter the execution environment.

409f46c

Carreau approved these changes Aug 12, 2020

View reviewed changes

vstinner reviewed Aug 12, 2020

View reviewed changes

Update Lib/codeop.py

09af3f5

Co-authored-by: Victor Stinner <vstinner@python.org>

terryjreedy merged commit c818b15 into python:master Aug 13, 2020

bedevere-bot removed the awaiting core review label Aug 13, 2020

terryjreedy deleted the tem branch August 13, 2020 17:18

miss-islington assigned terryjreedy Aug 13, 2020

terryjreedy added needs backport to 3.8 and removed needs backport to 3.8 labels Aug 13, 2020

terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Aug 13, 2020

[3.9] bpo-41520: Fix second codeop regression (pythonGH-21848)

64ee42c

Fix the repression introduced by the initial regression fix. (cherry picked from commit c818b15)

bedevere-bot removed the needs backport to 3.9 label Aug 13, 2020

terryjreedy added a commit that referenced this pull request Aug 13, 2020

[3.9] bpo-41520: Fix second codeop regression (GH-21848)

f24430f

Fix the repression introduced by the initial regression fix. (cherry picked from commit c818b15) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

bedevere-bot removed the needs backport to 3.8 label Aug 13, 2020

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020

bpo-41520: Fix second codeop regression (pythonGH-21848)

67cb1c9

* bpo-41520: Fix second codeop repression Fix the repression introduced by the initial regression fix.

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020

bpo-41520: Fix second codeop regression (pythonGH-21848)

3f8b7ed

* bpo-41520: Fix second codeop repression Fix the repression introduced by the initial regression fix.

Uh oh!

Conversation

terryjreedy commented Aug 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

terryjreedy commented Aug 12, 2020

Uh oh!

Carreau commented Aug 12, 2020

Uh oh!

vstinner Aug 12, 2020

Choose a reason for hiding this comment

Uh oh!

terryjreedy Aug 12, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington commented Aug 13, 2020

Uh oh!

miss-islington commented Aug 13, 2020

Uh oh!

miss-islington commented Aug 13, 2020

Uh oh!

miss-islington commented Aug 13, 2020

Uh oh!

miss-islington commented Aug 13, 2020

Uh oh!

miss-islington commented Aug 13, 2020

Uh oh!

miss-islington commented Aug 13, 2020

Uh oh!

bedevere-bot commented Aug 13, 2020

Uh oh!

terryjreedy commented Aug 13, 2020

Uh oh!

bedevere-bot commented Aug 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

terryjreedy commented Aug 12, 2020 •

edited

Loading