[3.8] bpo-41654: Explicitly cast PyExc_MemoryError to PyTypeObject to avoid warning#22102
Merged
pablogsal merged 1 commit intopython:3.8from Sep 5, 2020
Merged
[3.8] bpo-41654: Explicitly cast PyExc_MemoryError to PyTypeObject to avoid warning#22102pablogsal merged 1 commit intopython:3.8from
pablogsal merged 1 commit intopython:3.8from
Conversation
pablogsal
changed the title
shihai1991
reviewed
Sep 5, 2020
Objects/exceptions.c
Outdated
Member
There was a problem hiding this comment.
I got another compile warning: D:\a\1\s\Objects\exceptions.c(2324,56): warning C4098: 'MemoryError_dealloc': 'void' function returning a value [D:\a\1\s\PCbuild\pythoncore.vcxproj] in here.
Maybe we can cancel return?
Member
Author
There was a problem hiding this comment.
We cannot cancel it, but we can split the expression so the mvsc is happy.
shihai1991
approved these changes
Sep 5, 2020
Member
shihai1991
left a comment
shihai1991
left a comment
There was a problem hiding this comment.
Thanks for your update. LGTM now :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41654