bpo-35293: Remove RemovedInSphinx40Warning#22198

corona10 · 2020-09-11T11:42:36Z

https://bugs.python.org/issue35293

corona10 · 2020-09-11T11:43:54Z

The current failure is not related to this PR
See: https://bugs.python.org/issue41762

/Users/corona10/oss/cpython/Doc/library/string.rst:311:duplicate token description of sign, other instance in library/functions

vstinner · 2020-09-11T12:21:31Z

The current failure is not related to this PR

I don't understand. All jobs are now green. Did you re-run some jobs?

corona10 · 2020-09-11T12:32:59Z

I don't understand. All jobs are now green.

I expected that Travis CI - Pull Request will failed but not on this PR.

corona10 · 2020-09-12T09:17:31Z

@vstinner @njsmith Please take a look

vstinner · 2020-09-18T07:26:09Z

I fixed https://bugs.python.org/issue41762 with commit 8af239e, PR #22281.

corona10 · 2020-09-18T07:34:38Z

I fixed https://bugs.python.org/issue41762 with commit 8af239e, PR #22281.

Nice!, I rebased it!

vstinner · 2020-09-18T08:29:57Z

I confirm that the PR fix RemovedInSphinx40Warning warnings.

Without the PR:

$ cd Doc
$ make clean
$ make venv PYTHON=../python  && make html SPHINXOPTS="-j10"
(...)
/home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:310: RemovedInSphinx40Warning: PyClassmember is deprecated. Please check the implementation of <class 'pyspecific.PyCoroutineMethod'>
  return PyClassmember.run(self)
/home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:304: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyCoroutineFunction'>
  return PyModulelevel.run(self)
/home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:278: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyDecoratorFunction'>
  return PyModulelevel.run(self)
/home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:316: RemovedInSphinx40Warning: PyClassmember is deprecated. Please check the implementation of <class 'pyspecific.PyAwaitableFunction'>
  return PyClassmember.run(self)
/home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:278: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyDecoratorFunction'>
  return PyModulelevel.run(self)
/home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:278: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyDecoratorFunction'>
  return PyModulelevel.run(self)
/home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:310: RemovedInSphinx40Warning: PyClassmember is deprecated. Please check the implementation of <class 'pyspecific.PyCoroutineMethod'>
  return PyClassmember.run(self)
/home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:278: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyDecoratorFunction'>
  return PyModulelevel.run(self)
/home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:322: RemovedInSphinx40Warning: PyClassmember is deprecated. Please check the implementation of <class 'pyspecific.PyAwaitableMethod'>
  return PyClassmember.run(self)
/home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:278: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyDecoratorFunction'>
  return PyModulelevel.run(self)

With the PR, I don't see these warnings anymore:

$ cd Doc
$ make clean
$ make venv PYTHON=../python  && make html SPHINXOPTS="-j10"
(...)

Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst

Doc/tools/extensions/pyspecific.py

…cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org>

vstinner

LGTM.

miss-islington · 2020-09-18T09:22:39Z

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

* bpo-35293: Remove RemovedInSphinx40Warning * Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org> * bpo-35293: Apply Victor's review Co-authored-by: Victor Stinner <vstinner@python.org> (cherry picked from commit 6595cb0) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

bedevere-bot · 2020-09-18T09:22:52Z

GH-22302 is a backport of this pull request to the 3.9 branch.

corona10 · 2020-09-18T09:22:55Z

@vstinner Thank you Victor!

* bpo-35293: Remove RemovedInSphinx40Warning * Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org> * bpo-35293: Apply Victor's review Co-authored-by: Victor Stinner <vstinner@python.org> (cherry picked from commit 6595cb0) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

bedevere-bot · 2020-09-18T09:23:00Z

GH-22303 is a backport of this pull request to the 3.8 branch.

* bpo-35293: Remove RemovedInSphinx40Warning * Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org> * bpo-35293: Apply Victor's review Co-authored-by: Victor Stinner <vstinner@python.org> (cherry picked from commit 6595cb0) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

* bpo-35293: Remove RemovedInSphinx40Warning * Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org> * bpo-35293: Apply Victor's review Co-authored-by: Victor Stinner <vstinner@python.org>

corona10 requested a review from vstinner September 11, 2020 11:42

the-knights-who-say-ni added the CLA signed label Sep 11, 2020

bedevere-bot added the awaiting core review label Sep 11, 2020

corona10 added the skip news label Sep 11, 2020

corona10 changed the title ~~bpo-35293: Remove PyModulelevel deprecated warning~~ bpo-35293: Remove RemovedInSphinx40Warning Sep 12, 2020

corona10 removed the skip news label Sep 12, 2020

corona10 force-pushed the bpo-35293 branch from 946e6fd to 2b61a54 Compare September 12, 2020 08:48

corona10 requested a review from njsmith September 12, 2020 08:52

corona10 requested a review from terryjreedy September 16, 2020 10:04

terryjreedy removed their request for review September 16, 2020 12:23

corona10 force-pushed the bpo-35293 branch from f9d8ae6 to eff6180 Compare September 17, 2020 02:20

corona10 closed this Sep 17, 2020

corona10 reopened this Sep 17, 2020

corona10 closed this Sep 18, 2020

corona10 reopened this Sep 18, 2020

corona10 force-pushed the bpo-35293 branch from eff6180 to daa1277 Compare September 18, 2020 05:48

bpo-35293: Remove RemovedInSphinx40Warning

02f1485

corona10 force-pushed the bpo-35293 branch from daa1277 to 02f1485 Compare September 18, 2020 07:34

vstinner reviewed Sep 18, 2020

View reviewed changes

Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Outdated Show resolved Hide resolved

Doc/tools/extensions/pyspecific.py Show resolved Hide resolved

corona10 and others added 2 commits September 18, 2020 17:31

Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._…

acf117e

…cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org>

bpo-35293: Apply Victor's review

854ac4c

vstinner approved these changes Sep 18, 2020

View reviewed changes

bedevere-bot removed the awaiting core review label Sep 18, 2020

bedevere-bot added the awaiting merge label Sep 18, 2020

vstinner added needs backport to 3.8 labels Sep 18, 2020

corona10 merged commit 6595cb0 into python:master Sep 18, 2020

bedevere-bot removed the awaiting merge label Sep 18, 2020

bedevere-bot removed the needs backport to 3.9 label Sep 18, 2020

bedevere-bot removed the needs backport to 3.8 label Sep 18, 2020

corona10 deleted the bpo-35293 branch September 18, 2020 09:23

Uh oh!

Conversation

corona10 commented Sep 11, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

corona10 commented Sep 11, 2020

Uh oh!

vstinner commented Sep 11, 2020

Uh oh!

corona10 commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

corona10 commented Sep 12, 2020

Uh oh!

vstinner commented Sep 18, 2020

Uh oh!

corona10 commented Sep 18, 2020

Uh oh!

vstinner commented Sep 18, 2020

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Sep 18, 2020

Uh oh!

bedevere-bot commented Sep 18, 2020

Uh oh!

corona10 commented Sep 18, 2020

Uh oh!

bedevere-bot commented Sep 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

corona10 commented Sep 11, 2020 •

edited by bedevere-bot

Loading

corona10 commented Sep 11, 2020 •

edited

Loading