Skip to content

bpo-38323: Add guard clauses in MultiLoopChildWatcher.#22756

Merged
asvetlov merged 1 commit intopython:masterfrom
cjerdonek:issue-38323-multi-watcher-tweak
Dec 16, 2020
Merged

bpo-38323: Add guard clauses in MultiLoopChildWatcher.#22756
asvetlov merged 1 commit intopython:masterfrom
cjerdonek:issue-38323-multi-watcher-tweak

Conversation

@cjerdonek
Copy link
Member

@cjerdonek cjerdonek commented Oct 18, 2020 •
edited by bedevere-bot
Loading

This is a trivial refactor in preparation for a fix for bpo-38323 (see #20142).

https://bugs.python.org/issue38323

@cjerdonek
bpo-38323: Add guard clauses in MultiLoopChildWatcher.
f855209 
This is a trivial refactor in preparation for a fix for bpo-38323.
@cjerdonek cjerdonek mentioned this pull request Oct 18, 2020
Closed
@cjerdonek cjerdonek closed this Oct 19, 2020
@cjerdonek cjerdonek reopened this Oct 19, 2020
aeros
aeros approved these changes Nov 7, 2020
View reviewed changes
Copy link
Contributor

@aeros aeros left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delay, I got caught up with organizing the sprint (and participating the week of Oct. 19-23), then took a bit of a break after it was over.

With usage of guard clauses instead of an additional layer of nested indents though, I found it significantly easier to mentally parse (which makes a difference especially for someone less experienced w/ non-trivial signal handling, like myself). Also, thanks for splitting this refactor away from #20142, that definitely makes the review process easier.

@github-actions
Copy link

github-actions bot commented Dec 16, 2020

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@asvetlov asvetlov merged commit 66d3b58 into python:master Dec 16, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Dec 16, 2020

Thanks @cjerdonek for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Dec 16, 2020

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@asvetlov
Copy link
Contributor

asvetlov commented Dec 16, 2020

Thanks! Sorry for delay

@bedevere-bot
Copy link

bedevere-bot commented Dec 16, 2020

GH-23806 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2020
@cjerdonek @miss-islington
bpo-38323: Add guard clauses in MultiLoopChildWatcher. (pythonGH-22756)
8b27218 
This is a trivial refactor in preparation for a fix for bpo-38323.
(cherry picked from commit 66d3b58)

Co-authored-by: Chris Jerdonek <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2020
@cjerdonek @miss-islington
bpo-38323: Add guard clauses in MultiLoopChildWatcher. (pythonGH-22756)
db46071 
This is a trivial refactor in preparation for a fix for bpo-38323.
(cherry picked from commit 66d3b58)

Co-authored-by: Chris Jerdonek <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Dec 16, 2020

GH-23807 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Dec 16, 2020
@miss-islington @cjerdonek
bpo-38323: Add guard clauses in MultiLoopChildWatcher. (GH-22756)
bf0eed3 
This is a trivial refactor in preparation for a fix for bpo-38323.
(cherry picked from commit 66d3b58)

Co-authored-by: Chris Jerdonek <[email protected]>
miss-islington added a commit that referenced this pull request Dec 16, 2020
@miss-islington @cjerdonek
bpo-38323: Add guard clauses in MultiLoopChildWatcher. (GH-22756)
dd262ef 
This is a trivial refactor in preparation for a fix for bpo-38323.
(cherry picked from commit 66d3b58)

Co-authored-by: Chris Jerdonek <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@cjerdonek @adorilson
bpo-38323: Add guard clauses in MultiLoopChildWatcher. (python#22756)
b9a14d4 
This is a trivial refactor in preparation for a fix for bpo-38323.
@vstinner vstinner mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1

+1 more reviewer

@aeros aeros aeros approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cjerdonek @miss-islington @bedevere-bot @asvetlov @aeros @the-knights-who-say-ni