Skip to content

bpo-42243: Use PyModule_Add*() in _sre iso. direct module dict manipulation#23101

Closed
erlend-aasland wants to merge 3 commits intopython:masterfrom
erlend-aasland:bpo-42243/sre
Closed

bpo-42243: Use PyModule_Add*() in _sre iso. direct module dict manipulation#23101
erlend-aasland wants to merge 3 commits intopython:masterfrom
erlend-aasland:bpo-42243/sre

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Nov 2, 2020 •
edited by bedevere-bot
Loading

serhiy-storchaka
serhiy-storchaka reviewed Nov 2, 2020
View reviewed changes
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Nov 2, 2020

Just for the case, add tests that MAXREPEAT and MAXGROUPS > 0.

@erlend-aasland erlend-aasland marked this pull request as draft November 2, 2020 09:20
@erlend-aasland erlend-aasland marked this pull request as ready for review November 2, 2020 10:30
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Nov 2, 2020 •
edited
Loading

Just for the case, add tests that MAXREPEAT and MAXGROUPS > 0.

Would a simple assert() be sufficient, or did you mean adding a unit test?

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Nov 3, 2020

Would a simple assert() be sufficient, or did you mean adding a unit test?

I meant adding a test in Lib/test/test_re.py. If somebody will break this code in future it will get clearer test failure.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Nov 3, 2020

Would a simple assert() be sufficient, or did you mean adding a unit test?

I meant adding a test in Lib/test/test_re.py. If somebody will break this code in future it will get clearer test failure.

Got it. Signedness test added in 8561628.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Nov 17, 2020

@serhiy-storchaka are you ok with this PR as it stands?

@erlend-aasland erlend-aasland mentioned this pull request Nov 19, 2020
Merged
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Nov 19, 2020
Merge pythonGH-23101
12bf771
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Nov 20, 2020

Closing, as this was incorporated in #23393

@erlend-aasland erlend-aasland deleted the bpo-42243/sre branch December 26, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot