bpo-40939: Restore some stable API functions incorrectly deleted#23606
Merged
pablogsal merged 3 commits intopython:masterfrom Dec 2, 2020
Merged
bpo-40939: Restore some stable API functions incorrectly deleted#23606pablogsal merged 3 commits intopython:masterfrom
pablogsal merged 3 commits intopython:masterfrom
Conversation
gvanrossum
reviewed
Dec 2, 2020
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Shouldn't you also get rid of PyCompileString on line 1241? Because that's just a typo.
Member
Author
Done in 4989ebe |
gvanrossum
reviewed
Dec 2, 2020
gvanrossum
approved these changes
Dec 2, 2020
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Have you double checked that all these signatures match? (I haven't, I just trust that you know what you're doing. :-)
Member
Author
I have restored them as they were before the removal (so they should match whatever state they were in 3.8/3.9) and then I checked that all of them appear in |
Member
|
Sounds good then -- thanks for doing the due diligence!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40939