Skip to content

bpo-41224: Add versionadded for Symbol.is_annotated#23861

Merged
serhiy-storchaka merged 2 commits intopython:masterfrom
andresdelfino:is_annontated_versionadded
Dec 29, 2020
Merged

bpo-41224: Add versionadded for Symbol.is_annotated#23861
serhiy-storchaka merged 2 commits intopython:masterfrom
andresdelfino:is_annontated_versionadded

Conversation

@andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Dec 19, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 19, 2020
@serhiy-storchaka serhiy-storchaka changed the title [doc] Add versionadded for Symbol.is_annotated bpo-41224: Add versionadded for Symbol.is_annotated Dec 29, 2020
serhiy-storchaka
serhiy-storchaka requested changes Dec 29, 2020
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented Dec 29, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@andresdelfino @serhiy-storchaka
Update Doc/library/symtable.rst
a23bbb9 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@andresdelfino
Copy link
Contributor Author

andresdelfino commented Dec 29, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Dec 29, 2020

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

@serhiy-storchaka serhiy-storchaka merged commit 2edfc86 into python:master Dec 29, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

Thanks @andresdelfino for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

Sorry, @andresdelfino and @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2edfc86f69d8a74f4821974678f664ff94a9dc22 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

Sorry @andresdelfino and @serhiy-storchaka, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2edfc86f69d8a74f4821974678f664ff94a9dc22 3.8

@andresdelfino andresdelfino deleted the is_annontated_versionadded branch December 30, 2020 23:06
andresdelfino added a commit to andresdelfino/cpython that referenced this pull request Dec 30, 2020
@andresdelfino
[3.8] bpo-41224: Add versionadded for Symbol.is_annotated (pythonGH-2…
41e3533 
…3861).

(cherry picked from commit 2edfc86)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 30, 2020

GH-24016 is a backport of this pull request to the 3.8 branch.

andresdelfino added a commit to andresdelfino/cpython that referenced this pull request Dec 30, 2020
@andresdelfino
[3.9] bpo-41224: Add versionadded for Symbol.is_annotated (pythonGH-2…
da397dd 
…3861).

(cherry picked from commit 2edfc86)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 30, 2020

GH-24017 is a backport of this pull request to the 3.9 branch.

@serhiy-storchaka serhiy-storchaka removed their assignment Dec 31, 2020
serhiy-storchaka pushed a commit that referenced this pull request Dec 31, 2020
@andresdelfino
[3.9] bpo-41224: Add versionadded for Symbol.is_annotated (GH-23861). (…
7a7f3e0 
…GH-24017)

(cherry picked from commit 2edfc86)
serhiy-storchaka pushed a commit that referenced this pull request Dec 31, 2020
@andresdelfino
[3.8] bpo-41224: Add versionadded for Symbol.is_annotated (GH-23861). (…
bc15cdb 
…GH-24016)

(cherry picked from commit 2edfc86)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@andresdelfino @adorilson
bpo-41224: Add versionadded for Symbol.is_annotated (pythonGH-23861)
ae52678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@andresdelfino @bedevere-bot @miss-islington @serhiy-storchaka @Fidget-Spinner @the-knights-who-say-ni