Skip to content

bpo-40956: Convert _sqlite3.Row to Argument Clinic#23964

Merged
serhiy-storchaka merged 1 commit intopython:masterfrom
erlend-aasland:bpo-40956/part3-row
Dec 29, 2020
Merged

bpo-40956: Convert _sqlite3.Row to Argument Clinic#23964
serhiy-storchaka merged 1 commit intopython:masterfrom
erlend-aasland:bpo-40956/part3-row

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Dec 27, 2020 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Dec 27, 2020 •
edited
Loading

@corona10 Thanks for reviewing #23838! Here's the next PR in this series: Convert sqlite3.Row.__new__ and sqlite3.Row.keys to AC. This should be fairly easy to review :) I'm pretty sure all argument specs are in place this time ;)

@corona10 corona10 self-requested a review December 27, 2020 13:19
serhiy-storchaka
serhiy-storchaka approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@serhiy-storchaka serhiy-storchaka merged commit 84d79cf into python:master Dec 29, 2020
@erlend-aasland erlend-aasland deleted the bpo-40956/part3-row branch December 29, 2020 22:52
@erlend-aasland erlend-aasland mentioned this pull request Dec 30, 2020
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@adorilson
bpo-40956: Convert _sqlite3.Row to Argument Clinic (pythonGH-23964)
8808beb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

@corona10 corona10 Awaiting requested review from corona10

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @serhiy-storchaka @corona10 @the-knights-who-say-ni @bedevere-bot