bpo-40170: Always define PyExceptionClass_Name as a function

[erlend-aasland]

Remove the macro variant, as it accessed PyTypeObject.tp_name directly.

https://bugs.python.org/issue40170

[erlend-aasland]

@vstinner Would you mind reviewing this?

In related news: The NEWS item section for #24533, #24535, and #24548 were Core and Builtins, but in retrospect I see that C API would have been more fitting. Should I change them?

[vstinner]

In related news: The NEWS item section for #24533, #24535, and #24548 were Core and Builtins, but in retrospect I see that C API would have been more fitting. Should I change them?

Right, these changes impact the C API. If these changes were made after the latest Python 3.10 release, you can move the NEWS entries in a new PR. Otherwise, we can leave them, it's not a big deal.

[vstinner]

Merged, thanks.

The function is only used to display errors, so I don't think that we need to micro-optimize the code (add an internal static inline function, for example), it's not "hot code". I consider that error handling is "cold code".

[erlend-aasland]

Right, these changes impact the C API. If these changes were made after the latest Python 3.10 release, you can move the NEWS entries in a new PR. Otherwise, we can leave them, it's not a big deal.

All right. I prefer to move them before the next alpha. I'll throw up a PR.

Thanks for reviewing 🙏🏻