bpo-43795: Add a test for Stable ABI symbol availability using ctypes#26354

encukou · 2021-05-25T12:29:46Z

This is a cross-platform check that the symbols are actually
exported in the ABI, not e.g. hidden in a macro.

https://bugs.python.org/issue43795

This is a cross-platform check that the symbols are actually exported in the ABI, not e.g. hidden in a macro.

Tools/scripts/stable_abi.py

bedevere-bot · 2021-06-01T13:58:26Z

🤖 New build scheduled with the buildbot fleet by @encukou for commit 4278bc5 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

encukou · 2021-06-01T15:49:59Z

Aha, I didn't realize ctypes is an optional module. Thanks, Gentoo Installed with X PR buildbot!

bedevere-bot · 2021-06-01T15:54:25Z

🤖 New build scheduled with the buildbot fleet by @encukou for commit 39446ab 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

encukou · 2021-06-03T09:28:37Z

So, still not quite there:

AMD64 Arch Linux TraceRefs PR reports missing symbols PyModule_Create2 and PyModule_FromDefAndSpec2!
s390x Fedora Refleaks PR and x86 Gentoo Installed with X PR unrelated (test_asyncio timeout, test_idle failure)

vstinner · 2021-06-03T10:41:09Z

test_asyncio timeout

I guess that it's https://bugs.python.org/issue44112 Yesterday, I increased the buildbot timeout from 3 hours to 4 hours to be able to debug this issue.

test_idle failure

I should be fixed: https://bugs.python.org/issue44282

vstinner · 2021-06-03T10:42:00Z

AMD64 Arch Linux TraceRefs PR reports missing symbols PyModule_Create2 and PyModule_FromDefAndSpec2!

I guess that it's a similar issue than https://bugs.python.org/issue44133

We should try to link the Python binary from objects files (.o) rather than using the libpython static library.

github-actions · 2021-07-04T00:04:15Z

This PR is stale because it has been open for 30 days with no activity.

These aren't exported on some platforms. All the others should still be tested, though, to make sure they don't disappear.

bedevere-bot · 2021-10-21T13:36:13Z

🤖 New build scheduled with the buildbot fleet by @encukou for commit a0c765a 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

miss-islington · 2021-10-22T08:12:09Z

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

bedevere-bot · 2021-10-22T08:12:17Z

GH-29148 is a backport of this pull request to the 3.10 branch.

…pythonGH-26354) This is a cross-platform check that the symbols are actually exported in the ABI, not e.g. hidden in a macro. Caveat: PyModule_Create2 & PyModule_FromDefAndSpec2 are skipped. These aren't exported on some of our buildbots. This is a bug (bpo-44133). This test now makes sure all the others don't regress. (cherry picked from commit 276468d) Co-authored-by: Petr Viktorin <[email protected]>

Add a test for Stable ABI symbol availability using ctypes

12e08ff

This is a cross-platform check that the symbols are actually exported in the ABI, not e.g. hidden in a macro.

the-knights-who-say-ni added the CLA signed label May 25, 2021

bedevere-bot added the awaiting core review label May 25, 2021

encukou added the needs backport to 3.10 only security fixes label May 25, 2021

erlend-aasland reviewed May 25, 2021

View reviewed changes

Tools/scripts/stable_abi.py Show resolved Hide resolved

Rename the test class

c65dc41

encukou added the skip news label May 25, 2021

Remove reference to Py_FrozenMain

4278bc5

encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 1, 2021

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 1, 2021

Skip test when _ctypes is not available

39446ab

encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 1, 2021

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 1, 2021

github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 4, 2021

encukou added 3 commits October 21, 2021 13:24

Merge main branch

0cf75d2

Regenerate the test file

b5f7f0f

Skip the test for PyModule_Create2 & PyModule_FromDefAndSpec2

a0c765a

These aren't exported on some platforms. All the others should still be tested, though, to make sure they don't disappear.

encukou added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed stale Stale PR or inactive for long period of time. labels Oct 21, 2021

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 21, 2021

encukou merged commit 276468d into python:main Oct 22, 2021

bedevere-bot removed the awaiting core review label Oct 22, 2021

encukou deleted the pep652-ctypes2 branch October 22, 2021 08:12

bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 22, 2021

encukou mentioned this pull request Jun 7, 2022

Implement PEP 652 -- Maintaining the Stable ABI #87961

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bpo-43795: Add a test for Stable ABI symbol availability using ctypes#26354