bpo-43693: Clean up the PyCodeObject fields.#26364

ericsnowcurrently · 2021-05-25T20:19:14Z

move "hottest" fields to the top
otherwise group the fields a bit more clearly
add co_ncellvars and co_nfreevars

https://bugs.python.org/issue43693

Objects/codeobject.c

Lib/test/test_code.py

ericsnowcurrently added 5 commits May 25, 2021 13:01

Move up the comment about fields using in hashing/comparision.

5ff6c47

Group the fields more clearly.

c5aa5ee

Add co_ncellvars and co_nfreevars.

9a62e10

Use nlocals.

e48f0f0

Clarify a comment.

da9618b

ericsnowcurrently requested a review from markshannon May 25, 2021 20:19

the-knights-who-say-ni added the CLA signed label May 25, 2021

bedevere-bot added the awaiting core review label May 25, 2021

ericsnowcurrently added the skip news label May 25, 2021

This was referenced May 26, 2021

bpo-43693: Add _PyCode_New(). #26375

Merged

bpo-43693: Add _PyCode_New() and do some related cleanup. #26258

Closed

markshannon reviewed May 26, 2021

View reviewed changes

Objects/codeobject.c Outdated Show resolved Hide resolved

Raise ValueError if nlocals != len(varnames), rather than aborting.

ca08205

markshannon reviewed May 26, 2021

View reviewed changes

Lib/test/test_code.py Show resolved Hide resolved

Add a unit test for when co_nlocals != len(co_varnames).

9279114

markshannon merged commit 6cc800d into python:main May 26, 2021

bedevere-bot removed the awaiting core review label May 26, 2021

ericsnowcurrently deleted the code-object-cleanup-fields branch May 26, 2021 19:21

ericsnowcurrently mentioned this pull request May 27, 2021

Handle boxing of cell variables in the bytecode. faster-cpython/ideas#41

Closed

markshannon mentioned this pull request May 2, 2022

Logically merge cell and locals array. They are already contiguous in memory #87859

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bpo-43693: Clean up the PyCodeObject fields.#26364