Skip to content

bpo-43693: Revert commits 2c1e2583fdc4db6b43d163239ea42b0e8394171f and b2bf2bc1ece673d387341e06c8d3c2bc6e259747 #26530

Merged
pablogsal merged 2 commits intopython:mainfrom
pablogsal:revert-bpo-43693
Jun 4, 2021
Merged

bpo-43693: Revert commits 2c1e2583fdc4db6b43d163239ea42b0e8394171f and b2bf2bc1ece673d387341e06c8d3c2bc6e259747 #26530
pablogsal merged 2 commits intopython:mainfrom
pablogsal:revert-bpo-43693

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 4, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from tiran as a code owner June 4, 2021 16:32
@pablogsal
Copy link
Member Author

pablogsal commented Jun 4, 2021

The leaks are fixed after the revert:

❯ ./python -m test test_code -R :
0:00:00 load avg: 5.88 Run tests sequentially
0:00:00 load avg: 5.88 [1/1] test_code
beginning 9 repetitions
123456789
.........

== Tests result: SUCCESS ==

1 test OK.

Total duration: 709 ms
Tests result: SUCCESS

master on  main [$?⇡]  pyenv 3.9.1
❯ ./python  -m test test_exceptions -R :
0:00:00 load avg: 5.88 Run tests sequentially
0:00:00 load avg: 5.88 [1/1] test_exceptions
beginning 9 repetitions
123456789
.........

== Tests result: SUCCESS ==

1 test OK.

Total duration: 21.7 sec
Tests result: SUCCESS

@pablogsal pablogsal merged commit 17c4edc into python:main Jun 4, 2021
@pablogsal pablogsal deleted the revert-bpo-43693 branch June 4, 2021 16:51
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jun 7, 2021
Merged
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Jun 7, 2021
@ericsnowcurrently
Un-revert commits 2c1e258 and b2bf2bc.
5e98b69 
These were reverted in pythonGH-26530 (commit 17c4edc).

* Compute deref offsets in compiler (pythongh-25152)
* Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (pythongh-26388)
ericsnowcurrently added a commit that referenced this pull request Jun 7, 2021
@ericsnowcurrently
bpo-43693: Un-revert commits 2c1e258 and b2bf2bc. (gh-26577)
2ab27c4 
These were reverted in gh-26530 (commit 17c4edc) due to refleaks.

* 2c1e258 - Compute deref offsets in compiler (gh-25152)
* b2bf2bc - Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (gh-26388)

This change fixes the refleaks.

https://bugs.python.org/issue43693
@markshannon markshannon mentioned this pull request May 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@tiran tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pablogsal @the-knights-who-say-ni @bedevere-bot