[3.10] bpo-46433: _PyType_GetModuleByDef: handle static types in MRO (GH-30696)#31262
Merged
encukou merged 2 commits intopython:3.10from Feb 11, 2022
Merged
[3.10] bpo-46433: _PyType_GetModuleByDef: handle static types in MRO (GH-30696)#31262encukou merged 2 commits intopython:3.10from
encukou merged 2 commits intopython:3.10from
Conversation
encukou
changed the title
vstinner
approved these changes
Feb 10, 2022
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
There was just a minor change between while and for in the main branch, but with this change, 3.10 and main use "for", so it's better!
erlend-aasland
requested changes
Feb 10, 2022
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 0ef0853)
https://bugs.python.org/issue46433