Skip to content

bpo-47151: Fallback to fork when vfork fails in subprocess.#32186

Merged
gpshead merged 5 commits intopython:mainfrom
gpshead:subprocess-vfork-fail
Mar 31, 2022
Merged

bpo-47151: Fallback to fork when vfork fails in subprocess.#32186
gpshead merged 5 commits intopython:mainfrom
gpshead:subprocess-vfork-fail

Conversation

@gpshead
Copy link
Member

@gpshead gpshead commented Mar 30, 2022 •
edited by bedevere-bot
Loading

vfork() can return -1 and set errno. We now fall back to fork() in that situation as one possible error is EINVAL indicating that the kernel doesn't permit vfork from the current process. See the bug.

https://bugs.python.org/issue47151

@gpshead gpshead added type-bug An unexpected behavior, bug, or error needs backport to 3.9 needs backport to 3.10 only security fixes labels Mar 30, 2022
@gpshead gpshead marked this pull request as ready for review March 30, 2022 01:30
@gpshead gpshead requested a review from vstinner March 30, 2022 01:36
corona10
corona10 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :) Nice solution

vstinner
vstinner reviewed Mar 30, 2022
View reviewed changes
vstinner
vstinner reviewed Mar 30, 2022
View reviewed changes
vstinner
vstinner approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vstinner
vstinner reviewed Mar 31, 2022
View reviewed changes
@gpshead gpshead merged commit 4a08c4c into python:main Mar 31, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Mar 31, 2022

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@gpshead gpshead deleted the subprocess-vfork-fail branch March 31, 2022 20:42
@miss-islington
Copy link
Contributor

miss-islington commented Mar 31, 2022

Sorry, @gpshead, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4a08c4c469d36f99d3a5e0f17ad82ab35dcf2835 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 31, 2022
@bedevere-bot
Copy link

bedevere-bot commented Mar 31, 2022

GH-32219 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 31, 2022
@gpshead @miss-islington
bpo-47151: Fallback to fork when vfork fails in subprocess. (pythonGH…
cbc9705 
…-32186)

bpo-47151: Fallback to fork when vfork fails in subprocess. An OS kernel can specifically decide to disallow vfork() in a process. No need for that to prevent us from launching subprocesses.
(cherry picked from commit 4a08c4c)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington added a commit that referenced this pull request Mar 31, 2022
@miss-islington @gpshead
bpo-47151: Fallback to fork when vfork fails in subprocess. (GH-32186)
9ed179b 
bpo-47151: Fallback to fork when vfork fails in subprocess. An OS kernel can specifically decide to disallow vfork() in a process. No need for that to prevent us from launching subprocesses.
(cherry picked from commit 4a08c4c)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@socketpair socketpair mannequin mentioned this pull request May 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@corona10 corona10 corona10 approved these changes

+1 more reviewer

@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gpshead gpshead

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gpshead @miss-islington @bedevere-bot @vstinner @corona10 @raghavthind2005 @the-knights-who-say-ni