bpo-31234, socket.create_connection(): Fix ref cycle#3546
Merged
vstinner merged 1 commit intopython:masterfrom Sep 13, 2017
vstinner:create_connection
Merged
bpo-31234, socket.create_connection(): Fix ref cycle#3546vstinner merged 1 commit intopython:masterfrom vstinner:create_connection
vstinner merged 1 commit intopython:masterfrom
vstinner:create_connection
Conversation
gpshead
approved these changes
Sep 13, 2017
Member
gpshead
left a comment
gpshead
left a comment
There was a problem hiding this comment.
I'd rearrange the words in the comments to say "explicitly break" and "manually fixes" for correct English. Though people will understand it either way.
Member
Author
|
Hum, for the english, I will create a different PR since I copied the comment from somewhere else. |
Contributor
|
Thanks @Haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
GH-3552 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue31234