bpo-32101: Add PYTHONDEVMODE environment variable#4624
Merged
vstinner merged 4 commits intopython:masterfrom Nov 30, 2017
vstinner:pythondevmode
Merged
bpo-32101: Add PYTHONDEVMODE environment variable#4624vstinner merged 4 commits intopython:masterfrom vstinner:pythondevmode
vstinner merged 4 commits intopython:masterfrom
vstinner:pythondevmode
Conversation
vstinner
changed the title
Member
Author
|
Oh, test_sys fails in development mode, but it's unrelated to this PR: bug fixed by PR #4625. Another bug: test_faulthandler and test_asyncio now fail with PYTHONDEVMODE=1. |
Rename also the "Developer mode" to the "Development mode".
Mention it in the development chapiter.
Member
Author
|
I rebased my change to get the memory allocator fixes (commit 5d39e04), and I documented the "Python development mode" in the Development chapiter of the documentation. |
Member
Author
ncoghlan
approved these changes
Nov 30, 2017
Contributor
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
Looks good to me. I'm OK with the idea of committing to dev mode being an "all or nothing" toggle - the more fine-grained control already exists in the form of the underlying settings that dev mode groups together.
Lib/asyncio/coroutines.py
Outdated
| debug = (not sys.flags.ignore_environment and | ||
| bool(os.environ.get('PYTHONASYNCIODEBUG'))) | ||
| if hasattr(sys, '_xoptions') and 'dev' in sys._xoptions: | ||
| if sys.flags.dev_mode: |
Contributor
There was a problem hiding this comment.
Now the second check is shorter, this could be simplified to:
debug = sys.flags.dev_mode or (not sys.flags.ignore_environment and
bool(os.environ.get('PYTHONASYNCIODEBUG'))
return debug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add also the sys.flags.dev_mode flag.
https://bugs.python.org/issue32101