bpo-29240, bpo-32030: pymain_set_sys_argv() now copies argv#4838
Merged
vstinner merged 1 commit intopython:masterfrom Dec 13, 2017
vstinner:pymain_argv
Merged
bpo-29240, bpo-32030: pymain_set_sys_argv() now copies argv#4838vstinner merged 1 commit intopython:masterfrom vstinner:pymain_argv
vstinner merged 1 commit intopython:masterfrom
vstinner:pymain_argv
Conversation
bpo-29240, bpo-32030: * Rename pymain_set_argv() to pymain_set_sys_argv() * pymain_set_sys_argv() now creates of copy of argv and modify the copy, rather than modifying pymain->argv * Call pymain_set_sys_argv() earlier: before pymain_run_python(), but after pymain_get_importer(). * Add _PySys_SetArgvWithError() to handle errors
Member
Author
|
AppVeyor failed with: I'm unable to reproduce the issue on my Windows :-( |
Member
Author
This error is unrelated to this change: see https://bugs.python.org/issue32302 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copy, rather than modifying pymain->argv
after pymain_get_importer().
https://bugs.python.org/issue29240