bpo-34123: Fix missed documentation update for dict.popitem().#8292
Merged
rhettinger merged 2 commits intopython:masterfrom Jul 17, 2018
Merged
bpo-34123: Fix missed documentation update for dict.popitem().#8292rhettinger merged 2 commits intopython:masterfrom
rhettinger merged 2 commits intopython:masterfrom
Conversation
rhettinger
added
docs
tim-one
reviewed
Jul 16, 2018
Member
tim-one
left a comment
tim-one
left a comment
There was a problem hiding this comment.
Looks good to me. Just wondering whether it would be helpful to add a "version changed in" blurb too so readers know that relying on LIFO creates a version dependence.
Contributor
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-8307 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 17, 2018
rhettinger
pushed a commit
that referenced
this pull request
Jul 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34123