bpo-34170: Cleanup pymain_run_filename()#8631
Merged
vstinner merged 1 commit intopython:masterfrom Aug 2, 2018
vstinner:pymain_run_filename
Merged
bpo-34170: Cleanup pymain_run_filename()#8631vstinner merged 1 commit intopython:masterfrom vstinner:pymain_run_filename
vstinner merged 1 commit intopython:masterfrom
vstinner:pymain_run_filename
Conversation
* Inline pymain_run_file() and pymain_open_filename() into pymain_run_filename() * Created pymain_run_stdin() which is pymain_run_filename() with filename=NULL * Rename pymain_run_filename() to pymain_run_file()
ZackerySpytz
reviewed
Aug 2, 2018
| PyErr_SetFromErrnoWithFilename(PyExc_OSError, | ||
| startup); | ||
| PyErr_Print(); | ||
| PyErr_Clear(); |
Contributor
There was a problem hiding this comment.
There's no need to call PyErr_Clear() after PyErr_Print().
Member
Author
There was a problem hiding this comment.
This code is 11 years old, I didn't touch it. Please open a new issue if you want to fix it.
See commit e69a08e.
Contributor
There was a problem hiding this comment.
This has been fixed in 8b58468.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pymain_run_filename()
filename=NULL
https://bugs.python.org/issue34170