bpo-33649: Edit asyncio eventloop doc - second pass#9233
Merged
1st1 merged 3 commits intopython:masterfrom Sep 13, 2018
Merged
Conversation
1st1
reviewed
Sep 12, 2018
Member
1st1
left a comment
1st1
left a comment
There was a problem hiding this comment.
Looks good! I've left a few nit comments.
Doc/library/asyncio-eventloop.rst
Outdated
| loops and should use the :func:`asyncio.run` function to initialize | ||
| and run asynchronous code. | ||
| Application developers will typically use high-level asyncio functions | ||
| to interact with the event loop. In general,high-level asyncio applications |
Member
There was a problem hiding this comment.
Missing a space in general,high-level -> general, high-level
Doc/library/asyncio-eventloop.rst
Outdated
| Consider also using the :func:`asyncio.run` function instead of | ||
| manually creating and closing an event loop. | ||
| Consider also using the :func:`asyncio.run` function instead of using | ||
| lower level commands to manually create and close an event loop. |
Member
There was a problem hiding this comment.
Would it make sense to change "commands" to "functions" or "APIs"?
Doc/library/asyncio-eventloop.rst
Outdated
| * *family* can be set to either :data:`socket.AF_INET` or | ||
| :data:`~socket.AF_INET6` to force the socket to use IPv4 or IPv6. | ||
| If not set it will be determined from host name | ||
| If not set, it will be determined from host name |
Member
There was a problem hiding this comment.
Maybe "If not set, it will be determined" -> "If not set, the family will be determined"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33649