GH-93112: Fix missing ResourceDenied import in test_urllib2net#93113
GH-93112: Fix missing ResourceDenied import in test_urllib2net#93113vstinner merged 1 commit intopython:mainfrom The-Compiler:resource-denied-import
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
I believe this won't need a news entry - but it should probably be backported to 3.11 and 3.10? |
|
I confirm the bug without the fix: |
vstinner
added
needs backport to 3.10
yes, bugfixes are backported to stable branches: https://devguide.python.org/#status-of-python-branches |
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
An alternative would be to replace ResourceDenied with support.ResourceDenied, but I'm fine with this fix.
|
Right. Both are already used in the file, so I didn't know what to prefer. Happy to adjust if you prefer using |
|
Thanks @The-Compiler for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-93168 is a backport of this pull request to the 3.11 branch. |
|
GH-93169 is a backport of this pull request to the 3.10 branch. |
…ythonGH-93113) The code was moved out of test.support in 311110a (pythonGH-20812), thus making ResourceDenied undefined. (cherry picked from commit 37c9a35) Co-authored-by: Florian Bruhin <me@the-compiler.org>
…ythonGH-93113) The code was moved out of test.support in 311110a (pythonGH-20812), thus making ResourceDenied undefined. (cherry picked from commit 37c9a35) Co-authored-by: Florian Bruhin <me@the-compiler.org>
5 participants
The code was moved out of test.support in
311110a (GH-20812), thus making
ResourceDenied undefined.
Closes #93112.