gh-95132: Correctly relay *args and **kwds from sqlite3.connect to factory#95146
gh-95132: Correctly relay *args and **kwds from sqlite3.connect to factory#95146erlend-aasland merged 9 commits intopython:mainfrom
Conversation
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit b144689 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
Triggering the bots to be 100% sure we don't break 3.11 again. |
|
I've queued a commit that further improves the factory tests. I'll wait until the bots are done before pushing it, though 🤖 |
Bot run: 87 successful and 1 skipped checks 💯 |
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM, but <unrepresentable> makes the exact signature almost useless. And there is no need to use it, because the default value can be represented.
Thanks for reviewing! Yeah, that's a C&P artefact from the clinic generated docstring. I'll fix it. Thanks again! |
|
This PR also addresses the remaining concerns in #93044:
|
|
Both the second and the third concerns. |
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Yes, I've already updated my post. Also thanks for the last got'cha. |
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry, @erlend-aasland, I could not cleanly backport this to |
…connect to factory (pythonGH-95146) This PR partially reverts pythongh-24421 (PR) and fixes the remaining concerns given in pythongh-93044 (issue): - keyword arguments are passed as positional arguments to factory() - if an argument is not passed to sqlite3.connect(), its default value is passed to factory() Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>. (cherry picked from commit a3d4d15) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
|
GH-95158 is a backport of this pull request to the 3.11 branch. |
…t to factory (GH-95146) (#95158) This PR partially reverts gh-24421 (PR) and fixes the remaining concerns given in gh-93044 (issue): - keyword arguments are passed as positional arguments to factory() - if an argument is not passed to sqlite3.connect(), its default value is passed to factory() Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>. (cherry picked from commit a3d4d15) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
This PR partially reverts gh-24421 (PR) and fixes the remaining concerns
given in gh-93044 (issue).
Fixes gh-95132