Switchers handled by docsbuild-scripts.#91
Merged
JulienPalard merged 5 commits intopython:masterfrom Jun 18, 2020
Merged
Conversation
Member
Author
|
Looks like it works (local builds are usable, tested using The current implementation works without modifications on cpython, so it'll work on old branch we don't want to pollute with this, and we'll be able to clean the master branch later if this PR gets adopted. Please let me merge this PR myself, so I can closely watch how it goes on docs.pyhon.org immediatly after the merge (as salt will deploy this automatically after merging), to catch potential issues as early as possible, but reviews are appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #90
Tasks:
switchers.jsswitchers.jsfind the switcher place, even in the absence of span placeholders (cpython could help by adding proper ids, but it's also nice if it works on old branches in which we won't commit the proper ids).indexsidebar.htmlvar all_versionsandvar all_languagesare not duplicated betweenbuild_docs.pyandswitchers.js.indexsidebar.html.