Add a benchmark based on python -m pprint#222
Add a benchmark based on python -m pprint#222ericsnowcurrently merged 9 commits intopython:mainfrom arhadthedev:pprint
python -m pprint#222Conversation
|
This creative PR is a receiving half of python/cpython#94613. |
python -m pprintpython -m pprint
ericsnowcurrently
left a comment
There was a problem hiding this comment.
Thanks for working on this, Oleg! I've left some comments for you to consider.
pyperformance/data-files/benchmarks/bm_from_stdlib/pyproject.toml
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py
Outdated
Show resolved
Hide resolved
|
@ericsnowcurrently Thank you for your thorough feedback, I've addressed everything. In addition, I've also moved a class docstring into a file comment, and reworded it together with authorship. I hope I've made it right. Also I've added
Initially I've thought that a benchmark should be big, like |
ericsnowcurrently
left a comment
There was a problem hiding this comment.
Thanks for the updates.
This PR couples with python/pyperformance#222 and supersedes #92560. Inspired by #93096 (comment). Automerge-Triggered-By: GH:ericsnowcurrently
python -m pprintshould have tests or not.After merging, python/cpython#92546 needs to be closed.